Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of order batch #1853

Merged
merged 4 commits into from
May 7, 2022
Merged

Out of order batch #1853

merged 4 commits into from
May 7, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented May 7, 2022

No description provided.

@lxfind lxfind requested a review from gdanezis May 7, 2022 17:14
@lxfind lxfind marked this pull request as ready for review May 7, 2022 17:14
@lxfind lxfind force-pushed the out-of-order-batch branch from 22d2c1f to 6abf422 Compare May 7, 2022 17:36
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the bug!

@lxfind lxfind merged commit 60723c9 into main May 7, 2022
@lxfind lxfind deleted the out-of-order-batch branch May 7, 2022 18:56
longbowlu pushed a commit that referenced this pull request May 12, 2022
* Out of order batch test

* Fix notifier out of order bug

* Test stream is empty before tx0 is sent

* Test order

Co-authored-by: George Danezis <[email protected]>
punwai pushed a commit that referenced this pull request Jul 27, 2022
* Out of order batch test

* Fix notifier out of order bug

* Test stream is empty before tx0 is sent

* Test order

Co-authored-by: George Danezis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants