[script] Make move_dependency.py work for narwhal dependency as well #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asonnino
approved these changes
May 11, 2022
|
@asonnino The test failure seems to be related to shared objects. |
Did you rebase on main? There was an issue with the grpc layer. But it’s not entirely solve, we now have a more mysterious network issue |
lxfind
force-pushed
the
script-move-dep-work-for-narwhal
branch
from
ae9cc12 to
3f30739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to switch to narwhal local dependency with one command:
Similarly for upgrade revision.