Do not re-sequence replayed transactions #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asonnino
added
Priority: Low
lxfind
approved these changes
May 13, 2022
huitseeker
approved these changes
May 13, 2022
sui_types/src/error.rs
Outdated
| ConsensusNarwhalSerializationError(String), | ||
| #[error("Only shared object transactions need to be sequenced")] | ||
| OnlySharedObjectTransactionNeedSequencing, |
There was a problem hiding this comment.
NotASharedObjectTransaction maybe?
sui_core/src/authority_server.rs
Outdated
Comment on lines
219
to
222
| let ConsensusTransaction::UserTransaction(certificate) = &transaction; | ||
| let info = match self | ||
| .state | ||
| .try_skip_consensus(certificate) |
There was a problem hiding this comment.
You own the transaction, consider having try_skip_consensus take ownership of it.
See C-CALLER-CONTROL.
There was a problem hiding this comment.
Actually this is a good read (should have done it earlier): https://rust-lang.github.io/api-guidelines/about.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authority currently sequences every shared-object transaction it sees. This is fine, but we can skip consensus in the following cases: