wallet-ext: create & import flow #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also fixes webpack eslint plugin to check all the files
* force extension to open in main window when wallet is not initialized * create and import mnemonic * after creating a wallet show the mnemonic to the user to save for backup * NOTE: mnemonic is not encrypted for now
pchrysochoidis
force-pushed
the
pc-wallet-ui-home-page
branch
from
7be1062 to
a08db04
Compare
|
See video: "passphrase is not valid" does not prevent me from going into the next screen. CleanShot.2022-05-16.at.22.27.00.mp4 |
666lcz
reviewed
May 17, 2022
Thanks for the review @666lcz! This was done in order to just follow this
But I didn't care much about providing < 12 works, since in the end it creates a key. I will improve it and push a fix soon. Thanks |
|
@666lcz I fixed it, just disabled the button whenever the mnemonic is invalid. (Updated some of the dependencies as well) |
666lcz
approved these changes
May 17, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Views:
Create
Backup
Main view (after importing/creating a wallet)
part of #1849