Ensure all mutable objects are mutated #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://mysten-labs.slack.com/archives/C02GD7J9HUM/p1642618186086000,
In some cases, mutable objects will not be mutated. For example:
The datastore expects every mutable objects' sequence number to increase.
This PR forces that at the end of the order execution. It does so by: Change
written's key from ObjectRef to ObjectID, and then changedeletedinto a BTreeSet of ObjectID. These two combined allows us to quickly discover which objects fromactive_inputsare not mutated.Also added a test to verify that.
TODO:
Calling
to_object_reference()on an object involves non-trivial cost (runs hash). So if we are doing a lot of repeat calls toto_object_reference()towrittenwe could cache the reference in the map as well.