Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-json-rpc-spec: move into own crate and fix when run at repo … #2178

Merged
merged 1 commit into from
May 24, 2022

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented May 24, 2022

…root

This PR does 4 things:

  1. Move generate-json-rpc-spec functionality into its own crate
  2. Makes generate-json-rpc-spec a binary instead of an example
  3. Changes the integration test which ensures the checked-in format has been updated to use the binary pre-compiled by cargo before the test is invoked. This eliminates the odd extra compile that occurred when running this test
  4. Fixes the binary to not be depended on the directory it's run from in order to function properly.

@bmwill bmwill requested review from lxfind and patrickkuo May 24, 2022 03:40
@bmwill bmwill enabled auto-merge (rebase) May 24, 2022 04:04
Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Line 130 in main.rs seems to use a hardcoded path as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants