[sui framework] eliminate polymorphic delete in Transfer::delete_chil… #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
reviewed
May 24, 2022
crates/sui-adapter/src/adapter.rs
Outdated
Comment on lines
469
to
472
| Some((Owner::ObjectOwner(parent_id), _)) => { | ||
| parents_to_delete.insert(parent_id); | ||
| state_view.delete_object(obj_id, id.version(), DeleteKind::Normal) |
There was a problem hiding this comment.
Not quite follow this change. The reason it was implemented this way is because of line 494 where DeleteChildObject is handled separately (which signals that a child object is deleted together with a child ref, hence it's safe). Not sure if you could achieve the same without it.
I think you could make the ID::delete call a separate internal call to distinguish the case?
There was a problem hiding this comment.
Ahh I see how the old scheme worked now. Your suggested fix makes sense.
sblackshear
force-pushed
the
fix_polymorphic_delete
branch
2 times, most recently
from
a9504fe to
ad029d5
Compare
…d_object - Get rid of `Transfer::delete_child_object_internal`, which allowed deletion of a Move object without the `drop` ability (bad) - Adjust `Transfer::delete_child_object` to take the `VersionedID` of the child object rather than the object itself. This allows a Move programmer to delete a child object and `ChildRef` in the same transaction, but without exposing a polymorphic delete. - Refactored test of this function. This was the only call site - Changed the dynamic checks for dangling reference detection in the adapter. This is the biggest change here--please review carefully. The dynamic check previously complained if a child was deleted in the same tx as its parent, but that is too strict for the new implementation of `Transfer::delete_child_object`.
sblackshear
force-pushed
the
fix_polymorphic_delete
branch
from
ad029d5 to
079c3d3
Compare
lxfind
approved these changes
May 24, 2022
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d_object
Transfer::delete_child_object_internal, which allowed deletion of a Move object without thedropability (bad)Transfer::delete_child_objectto take theVersionedIDof the child object rather than the object itself. This allows a Move programmer to delete a child object andChildRefin the same transaction, but without exposing a polymorphic delete.Transfer::delete_child_object.