Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI config file serde and arg #251

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Fix CLI config file serde and arg #251

merged 1 commit into from
Jan 23, 2022

Conversation

oxade
Copy link
Contributor

@oxade oxade commented Jan 23, 2022 •
edited
Loading

Simple bugfixes

  1. Serde issue with transaction digests serde was failing due to JSON mapping the BTreeMap as a dictionary with string keys, however transaction digest was not being converted to string key which caused failures.
    Solution is to represent it as a vec in the cfg file
  2. CLI had redundant --from argument. Removed it and derived sender from gas obj. Moving forward, we'll take the sender secret also

@oxade oxade mentioned this pull request Jan 23, 2022
Closed
@oxade oxade merged commit e2ea50f into main Jan 23, 2022
@huitseeker huitseeker deleted the bugfix/cfg-file-serde-fails-due-to-tx-digest branch February 2, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblackshear sblackshear sblackshear approved these changes

@lxfind lxfind Awaiting requested review from lxfind

@awelc awelc Awaiting requested review from awelc

@patrickkuo patrickkuo Awaiting requested review from patrickkuo

@arun-koshy arun-koshy Awaiting requested review from arun-koshy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxade @sblackshear