Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adapter] Minor change to documentation for verify_and_link function #279

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

awelc
Copy link
Contributor

@awelc awelc commented Jan 27, 2022

Not the most sophisticated first PR, but one has to start somewhere... Also wanted to test PR creation mechanics.

In any case, it seems to me that the documentation for verify_and_link function is incorrect/out-of-date as the module id rewriting happens in generate_package_id function.

@awelc awelc self-assigned this Jan 27, 2022
@awelc awelc requested a review from sblackshear January 27, 2022 01:21
@awelc awelc merged commit ed4e171 into main Jan 27, 2022
@huitseeker huitseeker deleted the aw/publish-doc-change branch February 2, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants