[fastx client] Create a clean object reading interface (Part 4) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdanezis
changed the title
gdanezis
changed the title
gdanezis
changed the title
lxfind
approved these changes
Feb 9, 2022
fastpay_core/src/client.rs
Outdated
| @@ -48,6 +49,30 @@ pub struct ClientState<AuthorityAPI> { | |||
| store: ClientStore, | |||
| } | |||
|
|
|||
| pub enum ObjectRead { | |||
There was a problem hiding this comment.
ObjectReadResult is probably a better name?
There was a problem hiding this comment.
In Rust lingo Result usually suggests its a Result< something, something Error>, so I would stay away from that word.
fastpay_core/src/client.rs
Outdated
| impl ObjectRead { | ||
| pub fn object(&self) -> Result<&Object, FastPayError> { | ||
| match &self { | ||
| ObjectRead::Deleted(oref) => Err(FastPayError::ObjectDeleted { object_ref: *oref }), |
There was a problem hiding this comment.
You can use Self whenever ObjectRead is needed, so that if we ever rename the struct you don't need to change them.
There was a problem hiding this comment.
Great suggestion! Then we can work out what to call it.
gdanezis
force-pushed
the
check-authority-responses
branch
from
a50c41e to
2a7572a
Compare
gdanezis
force-pushed
the
clean-object-tests
branch
from
1466dad to
13c3c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectReadstructure with a clearExists,NotExists,Deletedset of enums.get_object_infoon client to just take object ID and return the last version as anObjectReadget_object_infosemanticsget_object_infologic