Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed-length address as object owner #457

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Use fixed-length address as object owner #457

merged 1 commit into from
Feb 16, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Feb 15, 2022

This PR is the first step towards #318: Object owner should be a fixed length address, instead of Authenticator.
This PR sets object owner to be SuiAddress, and change everywhere else to make the code compile.
To minimize the changes in this PR, a lot of work are left out to future PRs, including:

  1. We need to properly hash ObjectID into SuiAddress, instead of simply filling with 0s.
  2. We haven't touched the part around Authenticator, which needs to be extended to support different signing schemes
  3. We need to decouple SuiAddress and PublicKeyBytes as they are different concept.

Copy link
Collaborator

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sensible start to me--thanks!

@lxfind lxfind merged commit 5ced5e4 into main Feb 16, 2022
@lxfind lxfind deleted the fix-size-address branch February 16, 2022 00:09
@lxfind lxfind linked an issue Feb 16, 2022 that may be closed by this pull request
mwtian pushed a commit that referenced this pull request Sep 12, 2022
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] use hashes of Public Keys in Authenticator
3 participants