Decouple SuiAddress
and PublicKeyBytes
#467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step for #318.
Currently we are using
SuiAddress
andPublicKeyBytes
interchangeably. But they are different concept. Most of the time we should only be dealing withSuiAddress
, which is a hash ofPublicKeyBytes
(or a hash ofObjectID
when we represent object owners).There should only be two places where
PublicKeyBytes
are used:PublicKeyBytes
. There is no reason to useSuiAddress
for Authority name. In the future we could consider supporting different schemas for authority as well but for now we will stick with what we have.This PR does the following:
Base Types:
SuiAddress
, which is similar toPublicKeyBytes
in many ways, but different.Authenticator
. We no longer need this.Authority:
AuthorityInfo
struct should containAuthorityName
, instead ofSuiAddress
AuthorityPrivateInfo
doesn't needaddress
field.Client:
ClientState
now has a separateaddress
field andpub_key
field. This is a temporary state. Once we have a version ofStableSyncSigner
that can expose public key, we will remove thepub_key
field.SafeClient
's address needs to bePublicKeyBytes
, instead ofSuiAddress
.All over the code base:
Change the use from
PublicKeyBytes
toSuiAddress
as much as I can (except in Authority config and cases where I need it for signing/validating)