Delete unnecessary code in Client::transfer_object #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
approved these changes
Feb 19, 2022
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
Post #496 and in fact post the oneshot channel changes introduced in #486, the pending table of the Certificate Waiter can be accessed concurrently. In some cases, our benchmark has revealed that the drop triggered by a call to `clear()` can interact with the `drain()` operation to create a double-send on the same oneshot::Sender, which panics. (see comments on MystenLabs/narwhal@1474264 for evidence and re-run the bench locally at that commit to repro) This is now visible, because the GC actually fires more often post #496. This fixes the benchmark.
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Post MystenLabs#496 and in fact post the oneshot channel changes introduced in MystenLabs#486, the pending table of the Certificate Waiter can be accessed concurrently. In some cases, our benchmark has revealed that the drop triggered by a call to `clear()` can interact with the `drain()` operation to create a double-send on the same oneshot::Sender, which panics. (see comments on MystenLabs/narwhal@e2762bb for evidence and re-run the bench locally at that commit to repro) This is now visible, because the GC actually fires more often post MystenLabs#496. This fixes the benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already call
process_certificatesas part ofexecute_transaction.We also already handle deleted object as part of
update_objects_from_order_infoat the end of transaction execution.process_certificatesshould be a private function of AuthorityAggregator instead of public API.