Remove need for owner when fetching objects #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
approved these changes
Feb 22, 2022
| @@ -73,8 +84,8 @@ impl<A> ClientAddressManager<A> { | |||
| ClientState::new_for_manager( | |||
| address, | |||
| secret, | |||
| committee, | |||
| authority_clients, | |||
| self.committee.clone(), | |||
There was a problem hiding this comment.
Do these need to live both in ClientManager and ClientState, or can we get away with a single copy?
There was a problem hiding this comment.
No, we should remove it from ClientState.
In my next PRs on this topic will add shared ownership of client state as well as cleanup some of this stuff as part of #411
Co-authored-by: Sam Blackshear <[email protected]>
Co-authored-by: Sam Blackshear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves object info fetch to the manager/wallet level which avoids having to specify an owner for read-only operations.
The future plan is to move all read-only operations to top level.
CLI no longer needs to specify an owner/sender for operations. We can derive this from the gas.
Note:
Client could still use some cleanups in its data structures