Derive coin type in split and merge coin API #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
awelc,
patrickkuo,
sblackshear,
gdanezis,
666lcz and
oxade
lxfind
force-pushed
the
add-join-split-coin
branch
3 times, most recently
from
9fd53bd to
d16ab89
Compare
sblackshear
approved these changes
Feb 22, 2022
lxfind
force-pushed
the
add-join-split-coin
branch
from
d16ab89 to
052b8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting and merging coins in the Client API, we could derive the actual coin type by looking inside the type parameter of the coin struct tag.
Made the function a public static API of Coin, and added a few checks to make sure it's really a Coin type.