[fastx] Replace KeyPair With Signer & Load Keys From File #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
force-pushed
the
pat/wallet_key_store
branch
from
9c1a473 to
274b91c
Compare
patrickkuo
requested review from
oxade,
arun-koshy,
huitseeker,
kchalkias,
lxfind and
sblackshear
patrickkuo
force-pushed
the
pat/wallet_key_store
branch
from
a848f80 to
be46f49
Compare
lxfind
reviewed
Mar 1, 2022
sui_types/src/base_types.rs
Outdated
| @@ -87,6 +87,14 @@ impl From<ObjectID> for SuiAddress { | |||
| } | |||
| } | |||
|
|
|||
| impl From<Vec<u8>> for SuiAddress { | |||
There was a problem hiding this comment.
Converting from Vec to SuiAddress may not always succeed. So we may only want a TryFrom instead of From
The keystore can be used by the authorities in the future as well, the keystore trait can be extended to support HSM and other signing method, so it's not limited to the wallet |
666lcz
reviewed
Mar 1, 2022
sui_types/src/base_types.rs
Outdated
| @@ -87,6 +87,14 @@ impl From<ObjectID> for SuiAddress { | |||
| } | |||
| } | |||
|
|
|||
| impl From<Vec<u8>> for SuiAddress { | |||
| fn from(address: Vec<u8>) -> SuiAddress { | |||
There was a problem hiding this comment.
nit: Should we check the size of address here?
There was a problem hiding this comment.
Using TryFrom instead
|
This PR needs a thumbs up if it looks ok..... thanks :) |
666lcz
approved these changes
Mar 1, 2022
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add endpoint to publish multiaddr of nw primary * Fix broken test * use cluster in configuration tests * change addr to address * pass name instead of address to grpc server
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
* add endpoint to publish multiaddr of nw primary * Fix broken test * use cluster in configuration tests * change addr to address * pass name instead of address to grpc server
This was referenced Nov 10, 2022
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wallet.confkeystore.rsto store keys inwallet.keyKeystoreSignerinstead of Box<Pin>Not Implemented/ todos:
KeystoreSignerin Authorities