[fastx adapter] introduce bytecode rewriter for module handle substit… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
force-pushed
the
bytecode_rewrite
branch
2 times, most recently
from
3104ecc to
cbe59cf
Compare
…ution This offers a solution to the bytecode rewriting problem explained in MystenLabs/sui#71. Like any substitution scheme, the logic is rather intricate, so I have included lots of comments, `debug_assert`s, and tests.
sblackshear
force-pushed
the
bytecode_rewrite
branch
from
cbe59cf to
5d7908e
Compare
huitseeker
reviewed
Dec 20, 2021
Co-authored-by: François Garillot <[email protected]>
Co-authored-by: François Garillot <[email protected]>
huitseeker
approved these changes
Dec 20, 2021
Comment on lines
+145
to
+146
| (old_ids_for_friends.is_empty() && handle_index_sub_map.len() == self.sub_map.len()) | ||
| || handle_index_sub_map.len() <= self.sub_map.len() |
There was a problem hiding this comment.
Nit: I think what I was hinting at is that I suspect handle_index_sub_map.len() + old_ids_for_friends.len() = self.sub_map.len() in all cases?
There was a problem hiding this comment.
Ah good question--this doesn't hold if module id I is both a friend and in the module handles table. There's a test that exercises this scenario.
My invariant is a bit convoluted, but I think it's the strongest thing that's true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ution
This offers a solution to the bytecode rewriting problem explained in #71. Like any substitution scheme, the logic is rather intricate, so I have included lots of comments,
debug_asserts, and tests.Once #72 lands, we can call this from the
publishcode path to resolve several TODO's (supporting multi-module publishing, stop unsafe clobbering ofselfaddress, ...).