Check transfer gas cost upfront #912
Conversation
| @@ -204,6 +198,25 @@ impl AuthorityState { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn check_gas_requirement( | |||
There was a problem hiding this comment.
I have a question: are we not eventually have each transaction specify what is the maximum upper gas limit, and check that the gas object meets this limit (and also a conversion rate to SUI). This is what I assumed we would be doing. This means that we always know ahead of time what to check (ie. has the gas object at least this upper limit) and then later we can check if that limit is somehow exceeded.
There was a problem hiding this comment.
@sblackshear probably has a view on this.
There was a problem hiding this comment.
The Transfer transaction currently doesn't have a gas budget. But it seems reasonable to add it.
There was a problem hiding this comment.
That is probably the one for which this is a trivial constant? As you leverage in the PR I think.
There was a problem hiding this comment.
I am pretty sure this is bad/wrong: today the gas cost of a transfer is proportional to the size of the object :p
lxfind
force-pushed
the
check-transfer-gas-upfront
branch
2 times, most recently
from
fc58f0a to
c24142d
Compare
lxfind
force-pushed
the
check-transfer-gas-upfront
branch
from
c24142d to
2572424
Compare
In the current implementation, during handle_transaction, we only check that the gas object has some minimum amount of balance, and if in the end it's not enough to pay for the transfer, we fail at the confirmation step.
This is unnecessary. Object transfer has deterministic cost that we can determine upfront.
This PR changes the check of gas requirement for Transfer to compute the Transfer cost directly and check it against the balance. This requires accessing the transfer object, so the code is moved around to make this possible.