[Bench] Fix a few issues in benchmark #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
fix-bench-invariant
branch
from
089dd5f to
de1b281
Compare
lxfind
changed the title
lxfind
force-pushed
the
fix-bench-invariant
branch
from
de1b281 to
ea8278b
Compare
lxfind
force-pushed
the
fix-bench-invariant
branch
from
ea8278b to
3814581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
When we use multiple TCP connections, requests are broken into chunks and each chunk will be sent in parallel. We need to make sure that when we break them into chunks, we don't break any tx/cert pair, which would end up cert sending earlier before tx, causing tx failures. Added an assertion for this to make sure correct config is provided.
batch_send_one_chunkis incorrect. It would always miss the last response. Fix it.