fix pressure error in Kessler: replace cube_mod with e3sm version and other bug fixes. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixes in dyn_comp and update to namelist definition defaults
|
@PeterHjortLauritzen would you review this I can't commit without someone else approving. I fixed 2 bugs in dyn_comp (set use_moisture and initialize dp3d. I also replaced my badly merged version of cube_mod with a version that was close to e3sm. The code still needs a lot of cleanup which I will continue with once this is in. |
|
superseded by #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kessler was showing banding errors in the pressure field after a few timesteps. I was using the wrong version of cube_mod.F90 and replaced it with a slightly modified e3sm version. I also discovered that I wasn't setting the use_moisture flag which is used in the theta-l dycore to identify moist pressure. I also needed to initialize dp3d. With these changes the pressure artifacts are gone.