Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple instances of local_name in Cap. #630

Closed
dustinswales opened this issue Jan 29, 2025 · 1 comment
Closed

Allow for multiple instances of local_name in Cap. #630

dustinswales opened this issue Jan 29, 2025 · 1 comment
Labels
bug For issues describing bugs, or PRs fixing bugs

Comments

@dustinswales
Copy link
Collaborator

dustinswales commented Jan 29, 2025

Description

Allow for multiple instances of the same local_name being used in the Group cap:
a) with different standard_names
b) as part of different DDTs.

Steps to Reproduce

Using the var_compatability_test, add three new scalar variables (e.g. var_a, var_b, and var_c) that use the same local_name (scalar_var) within the Group. Then pass scalar_var_a into effrr_pre, scalar_var_b into effrr_post, and scalar_var_c into effrr_diag,
This will create a fortran runtime error due to the fact the same local_name is used three times within the Cap, scalar_var1.

@cacraigucar You mentioned an issue with reusing the same local_name, so it's possible this will address that.

@dustinswales dustinswales added the bug For issues describing bugs, or PRs fixing bugs label Jan 29, 2025
peverwhee pushed a commit that referenced this issue Feb 12, 2025
Description:
Allow for multiple instances of the same local_name being used in the
Group cap for two situations:
a) with different standard_names
b) in different DDTs .

User interface changes?: No

Fixes: #629 

Testing:
Added to var_compatibility_test to exercise feature.

This PR contains changes included in #630

---------

Co-authored-by: Dom Heinzeller <[email protected]>
@dustinswales
Copy link
Collaborator Author

Addressed in #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues describing bugs, or PRs fixing bugs
Projects
None yet
Development

No branches or pull requests

1 participant