Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize ncharts #19

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from
Open

Dockerize ncharts #19

wants to merge 48 commits into from

Conversation

erikj
Copy link
Contributor

@erikj erikj commented Oct 18, 2016 •
edited
Loading

Pull request for review and discussion:

  • dockerizes ncharts by
    • adding configuration to utilize official Python image and support required services via Docker Compose
    • moving hard-coded production paths to environment variables, namespaced w/ NCHARTS_ prefix
  • switch from Apache + mod_wsgi to Nginx + gunicorn, for lighter and easier to debug environment
  • config: docker/
  • documentation: docs/DOCKER.md, docker/README.md
  • demo: http://datavis-dev.eol.ucar.edu:8000/

Resolves #15

erikj added 30 commits October 6, 2016 13:53
@erikj
add Dockerfile for ncareol/alpine-node-bower; #15
b3efe6a
@erikj
ncareol/alpine-node-bower: add documentation; #15
f9b54ec
@erikj
add nginx config for 'web' Docker Compose service; #15
8ac5b90
@erikj
add Docker Compose file for 'assets' service; #15
015e181
@erikj
add default location for Docker Compose file to .gitignore; #15
aeb7bb3
@erikj
add Dockerfile for ncareol/python3-django-datavis:0.0.3, Docker image…
258bb30 
… for running ncharts Django application w/ gunicorn; #15
@erikj
add documentation for ncareol/python3-django-datavis:0.0.3, #15
765b19d
@erikj
assets service: use built image, rather than building; #15
1950db1
@erikj
add some documentation for docker/; 15
d1831a6
@erikj
clean up documentation for docker/; #15
c867441
@erikj
allow log level and var directories: log, run, lib, to be set via env…
0527a43 
…ironment variables; #15
@erikj
add local.docker to ALLOWED_HOSTS; #15
f2e363d
@erikj
fix assignment of LOG_LEVEL to handlers when LOG_DIR does not change; #…
1dc8552 
…15
@erikj
settings: s/LIB-DIR/DB_DIR/; #15
a6436b5
@erikj
settings: default DB_DIR to BASE_DIR; #15
c606e18
@erikj
settings: allow memcached to be configured to TCP/IP host:port, rathe…
0c5c8b2 
…r than just unix socket, via s/VAR_RUN_DIR/MEMCACHED_LOCATION/; #15
@erikj
settings: whitespace; #15
6fc828d
@erikj
production settings: default LOG_DIR to BASE_DIR; #15
d5b5fa0
@erikj
Docker Compose: add base config file; #15
6a24978
@erikj
Docker Compose: add ops config file; #15
23cc9c1
@erikj
Docker Compose: move config file for assets service into docker/ dir; #…
084b405 
…15
@erikj
Docker Compose: add starter dev override config; #15
c3196bb
@erikj
Docker Compose: update comments for assets-service config file; #15
d883e29
@erikj
Docker / Compose: add some basic usage documentation; #15
df5ed73
@erikj
Docker / Compose documentation: update command for ops invocation; #15
7e44665
@erikj
Docker Compose base config: format and enhance documentation comment; #…
f70357f 
…15
@erikj
Docker Compose config: whitespace; #15
9e52869
@erikj
documentation: refactor README to reference native and Docker set ups; …
28427de 
…#15
@erikj
documentation: correct typos; #15
e6e6754
@erikj
documentation: correct typo; #15
52cb8fc
erikj added 13 commits October 14, 2016 14:25
@erikj
documentation: add link to EOL; #15
04136a8
@erikj
Docker Compose: add systemd service files for datavis, datavis-dev, v…
a77c1c8 
…agrant; #15
@erikj
Docker documentation: add systemd instructions; #15
1fb51ab
@erikj
Docker Compose, assets: update path since file was moved into docker/; …
80d94f9 
…#15
@erikj
Docker, assets: install git, which is required by bower; #15
199cbf4
@erikj
Docker, assets: update referenced image to :0.0.2; #15
fb05188
@erikj
gunicorn: add default config file; #15
aa88088
@erikj
Docker Compose: add docker-compose.override.yml to .gitignore; #15
431f531
@erikj
Docker, Compose documentation: add 'about' content; #15
f5ed22f
@erikj
Merge branch 'develop' into feature-15-docker-nginx-unicorn
a346554
@erikj
Merge branch 'develop' into feature-15-docker-nginx-unicorn
00b9cee
@erikj
add convenience file to be sourced to load datavis env vars; #15
2a6282a
@erikj
environment variables: standardize on NCHARTS_ namespace, instead of …
268b925 
…DATAVIS_ and EOL_DATAVIS_; #15
@erikj
Copy link
Contributor Author

erikj commented Oct 18, 2016

This isn't the most atomic pull request, but some of the big advantages that it provides:

  • Moves the Python execution environment out of package management, so we don't have to build and maintain our own Python 3 packages. Staying up to date on security fixes will be much easier.
  • Decouples the web server and the execution environment dependencies by removing mod_wsgi.
  • Makes spinning up a new environment much easier, faster, consistent and reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nginx?
1 participant
@erikj