cmake in the FV3 dycore #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup of ccpp/CMakeLists.txt now that CCPP is defining build interfaces correctly
14 tasks
aerorahul
requested review from
DusanJovic-NOAA,
climbfuji and
junwang-noaa
climbfuji
reviewed
Sep 22, 2021
junwang-noaa
approved these changes
Sep 23, 2021
|
dycore PR was merged, new hash is ab026b7 |
DusanJovic-NOAA
approved these changes
Sep 23, 2021
climbfuji
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the CMake build of the dycore from fv3atm into GFDL_atmos_cubed_sphere
This cleans up the fv3atm
CMakeLists.txtIs a change of answers expected from this PR? No.
Issue(s) addressed
closes #390
Testing
How were these changes tested? Standard UFS regression tests.
What compilers / HPCs was it tested with? Covered under standard UFS regression tests.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform? In progress
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? Yes.
If so add the "waiting for other repos" label and list the upstream PRs