Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libyaml to ncrc make template files #41

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

ceblanton
Copy link
Contributor

Needed for the transition from *_table ascii input files to *_yaml files

@underwoo
Copy link
Member

underwoo commented Nov 4, 2021

The ncrc system has the pkgconfig files available for lilbyaml yaml-0.1. The information can be collected via the commands:

pkg-config --libs yaml-0.1
pkg-config --cflags yaml-0.1

I think it would be better to use pkg-config.

Another option would be to have ORNL add the correct bits to the libyaml files to have the ftn and cc wrappers do this for us automatically.

@ceblanton
Copy link
Contributor Author

Fixed. Thanks @underwoo, that's much better, I agree. I also tested the Intel one on gaea which worked.

@ceblanton
Copy link
Contributor Author

If you can, please quash these 4 commits into one during merging (the first 3 commits don't have much use in the git history). The message in the last commit is the most informative. Thanks!

@uramirez8707
Copy link
Collaborator

@ceblanton @underwoo Can this be merged and added to fre/test soon?
FMS main is now using libyaml and this will be helpful when testing.

@ceblanton
Copy link
Contributor Author

@underwoo OK to merge? We also should create a tag before using it in fre/test.

@ceblanton ceblanton requested review from underwoo and removed request for underwoo November 22, 2021 15:27
@underwoo underwoo merged commit 9ed9ce9 into NOAA-GFDL:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants