Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable waterbody execution in pybind/troute test #400

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

hellkite500
Copy link
Contributor

@hellkite500 hellkite500 commented Mar 18, 2022

The t-route waterbody input structure has changed enough that the test input file doesn't conform to the required inputs. Until the inputs can be fixed, simply disabling the waterbody execution portion of the t-route run will allow the test to still execute a simple routing test via the pybind interface in ngen.

Also added a runner to test the routing adapter integration with the ngen framework.

Changes

  • disable waterbody execution in t-route configuration for pybind/troute test

Testing

  1. Using the correct t-route submodule (bump t-route submodule commit to include bugfixes #399) should allow the test to pass with this config change.

Todos

  • Fix the watebody-params.json to conform to latest waterbody/lake definition (and probably create a lakes.json) sorry @mikejohnson51 😄

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOS

@hellkite500 hellkite500 requested a review from mattw-nws March 18, 2022 20:09
@mikejohnson51
Copy link

Is there a documented waterbody/lake definition I can look at?

@hellkite500
Copy link
Contributor Author

hellkite500 commented Mar 18, 2022

Is there a documented waterbody/lake definition I can look at?

We worked out some things before AGU, I have the example files from HUC01 if that helps?
All that is really needed here is for this test data set in test/data/routing to be updated.

@hellkite500 hellkite500 force-pushed the t-route-test-fix branch 5 times, most recently from 0150680 to 60d9c8d Compare March 18, 2022 20:45
@mattw-nws mattw-nws merged commit ded3284 into NOAA-OWP:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants