Update to Vector{DateTime} in Results
#1250
Merged
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (63.15%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 77.60% 77.28% -0.33%
==========================================
Files 124 124
Lines 13840 13693 -147
==========================================
- Hits 10741 10582 -159
- Misses 3099 3111 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Performance Results
|
jd-lara
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR with: NREL-Sienna/InfrastructureSystems.jl#438
The main change is related when having to do read_realized_terms in a Simulation and generating the ranges in DecisionProblems without having available the methods for step.
The main problem happens now when you received a single simulation step or a single time step, and having to create a step in that case.
The approach here is covering all the previous cases to properly have the necessary intervals and resolutions in those cases. It took some time to debug this. Tests are passing locally with the proper IS branch:
Also updated the printing as we don't have step now.