Breaking changes to consider

[joseph-robertson]

Enhancement Request

Checklist:

• CoolingTower:*Speed
  • evaporationLossMode (boost::optional<std::string> to std::string)
  • blowdownCalculationMode (boost::optional<std::string> to std::string)
  • cellControl for CoolingTower:VariableSpeed
• EvaporativeFluidCooler:SingleSpeed
  • performanceInputMethod (make required-field, and change boost::optional<std::string> to std::string)

[jmarrec]

• PlantLoop:
  • @eringold reported: commonPipeSimulation (optionalString to std::string, it has an IDD default)

    OpenStudio/src/model/PlantLoop.hpp

    Line 141 in 5cbad13

    boost::optional<std::string> commonPipeSimulation() const;

    . The ctor puts it to blank FYI:

    OpenStudio/src/model/PlantLoop.cpp

    Line 1236 in 5cbad13

    setString(OS_PlantLoopFields::CommonPipeSimulation, "");

[eringold]

Extending the PlantLoop bullet: might want to consider a commonPipeSimulationValues static member function, returning ["None", "CommonPipe", "TwoWayCommonPipe"].

[tijcolem]

merged in #4548