Fix #3430 - Four pipe beam crash in remove #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urPipeBeam::remove()
…onnected to same plantloop (OS App in particular) Typo
jmarrec
force-pushed
the
PR_opened/Fix_3430_FourPipeBeamCrash
branch
from
d87377a to
615de27
Compare
|
Force pushed because I did an interactive rebase to reorder the commits so that all tests (including for addBranchForZone, which I added later) would come first before fixes. |
…30_FourPipeBeamCrash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3430: add AirTerminalSingleDuctConstantVolumeFourPipeBeam::remove() method
Started by adding the unit test, then fixed it (TDD). You can checkout first commit to see it fail before fix.
Later realized I also needed to change
AirLoopHVAC::addBranchForZone(ThermalZone&)to handle reconnection of the cloned last ATU's cooling/heating coils for use in OS App in particular.