simple_battery unit tests #64
Conversation
There was a problem hiding this comment.
This is great, thanks for doing this @ZackTully ! If it's not too much to ask, would you do something similar for the HerculesWindBatteryController in WHOC? I already have a placeholder for that here. I also have some ideas for cleaning up the HerculesWindBatteryController a bit, but it would be great to have the tests in place before I/we do that
|
@misi9170 Sure! I'll take a look at it later today. |
* Setting up example to work through. * bugfix: fix old dummy name. * Constructs fi object. * appears to run as expected. * Various updates for smoother running. * Ruff. * Remove gch yaml in favor of a default dictionary defined in floris_standin.py * Undo ruff format, which fights with ruff. * Tests for FlorisStandin. * ruff * Adding correct floris branch to github workflow for testing. * try again... * and again. * ready to test external data. * Test for external data built out and passing. * ruff. * Remove obselete handling. * match reconfiguration of turbine package. * add pip install instructions. * ruff :( * Standin power specified in kW; emulator uses correct actuator. * Update test to reflect kW units. * remove unused JoukowskyDisk information. * Adding a comment explaining units in Floris power calculation * Adjusting to meet Ruff standards * Line shortened. --------- Co-authored-by: Genevieve Starke <[email protected]>
Co-authored-by: jfrederik-nrel <[email protected]>
That's a bit strange... I'll look into that a little, thanks for pointing that out @genevievestarke |
|
@ZackTully @genevievestarke Ok that issues with the comparison is fixed. I'm going to review the corresponding PR on WHOC and then should be able to merge both. |
|
Ok, great, sounds good! |
|
@ZackTully Thanks for the updates; I'm going to go ahead and merge this and the companion on WHOC. |
Unit tests for
SimpleBatterymodule.Resolves #53