Adding PV module unit tests and documentation #79
Conversation
…solar-pysam tried to push to origin solar-pysam but wasn't able to because this branch was behind the remote by a commit
|
I believe it's best practice for the unit tests to be totally self-contained. At the moment, this test requires the |
Merging develop into local branch to prepare for PR back to NREL develop
| assert outputs_init["power"] == 25 | ||
| assert outputs_init["irradiance"] == 1000 | ||
|
|
||
| # change simple battery state as if during simulation |
There was a problem hiding this comment.
Can we update the comments so that it's more clear what the part of the solar simulation it's testing?
There was a problem hiding this comment.
Yes, good idea.
There was a problem hiding this comment.
Do you know what the changes to this file were?
There was a problem hiding this comment.
It was the ruff formatting (ordering the imported packages alphabetically), but I'm confused as to why these changes are showing up here since I merged develop into my local branch
hercules/py_sims.py
Outdated
| @@ -49,6 +49,10 @@ def __init__(self, input_dict): | |||
| def get_py_sim(self, py_sim_obj_dict): | |||
| if py_sim_obj_dict["py_sim_type"] == "SimpleSolar": | |||
| return SimpleSolar(py_sim_obj_dict, self.dt) | |||
|
|
|||
There was a problem hiding this comment.
Is this section in the files twice?
There was a problem hiding this comment.
It looks like yes. Maybe this happened when I pulled in changes from develop? Not sure, but I'm fixing it now.
brookeslawski
changed the title
|
You'll notice that |
Addressing Issues #54 and #67
This PR adds unit tests and documentation for the
SolarPySAMmodule and corrects/improves some of the variable names.