Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GOLANG_VERSION in Dockerfile #1030

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Update GOLANG_VERSION in Dockerfile #1030

merged 2 commits into from
Oct 31, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Oct 31, 2024

Fixes #1008

@elezar elezar mentioned this pull request Oct 31, 2024
Open
tariq1890
tariq1890 previously approved these changes Oct 31, 2024
View reviewed changes
ArangoGutierrez
ArangoGutierrez approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint is now happy (or ignored)

@elezar
Copy link
Member Author

elezar commented Oct 31, 2024

golangci-lint is now happy (or ignored)

I did not want to make more expansive changes on a release branch.

@ArangoGutierrez
Copy link
Collaborator

golangci-lint is now happy (or ignored)

I did not want to make more expansive changes on a release branch.

I agree

@elezar elezar merged commit d2a5d54 into NVIDIA:release-0.16 Oct 31, 2024
7 checks passed
@elezar elezar deleted the fix-dockerfile branch October 31, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@tariq1890 tariq1890 tariq1890 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elezar @ArangoGutierrez @tariq1890