Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate dates and default issuance range #199

Closed
kevgliss opened this issue Jan 1, 2016 · 0 comments
Closed

Validate dates and default issuance range #199

kevgliss opened this issue Jan 1, 2016 · 0 comments
Labels
enhancement in progress
Milestone
0.3.x

Comments

@kevgliss
Copy link
Contributor

kevgliss commented Jan 1, 2016

We need to to a better job at handling not_before and not_after attributes.

lemur/lemur/certificates/views.py

Line 325 in 9e0b9d9

self.reqparse.add_argument('validityStart', type=str, location='json') # TODO validate

We should not only validate that they are proper dates, we should create and set values for:

MAX_CERTIFICATE_LENGTH=2
DEFAULT_ISSUEANCE_LENGTH=2

Values will be in years.
@kevgliss kevgliss added this to the 0.3.x milestone Apr 18, 2016
@kevgliss kevgliss mentioned this issue Apr 26, 2016
Closed
kevgliss added a commit to kevgliss/lemur that referenced this issue May 1, 2016
@kevgliss
Closes Netflix#278 and Netflix#199, Starting transition to marshmallow
47a5f70
kevgliss added a commit that referenced this issue May 5, 2016
@kevgliss
Closes #278 and #199, Starting transition to marshmallow (#299)
52f44c3 
* Closes #278  and #199, Starting transition to marshmallow
@kevgliss kevgliss closed this as completed May 5, 2016
kevgliss added a commit to kevgliss/lemur that referenced this issue May 5, 2016
@kevgliss
Closes Netflix#278 and Netflix#199, Starting transition to marshmallow (
4bf7971 
Netflix#299)

* Closes Netflix#278  and Netflix#199, Starting transition to marshmallow
nezdolik pushed a commit to spotify/lemur that referenced this issue Mar 23, 2023
Merge pull request Netflix#199 from atc/fix-build
0f20aca 
add toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress
Projects
None yet
Milestone
0.3.x
Development

No branches or pull requests
1 participant
@kevgliss