add UseIPAddrForServer configuration to not require DNS for 2.x/master #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ribbon-pull-requests #172 SUCCESS |
aspyker
changed the title
|
Just a note that while I have tested the 1.x stream jars in an end to end application, for 2.x I have no such application, so the only testing I have performed is the unit test provided. |
| @@ -89,6 +90,8 @@ public void initWithNiwsConfig(IClientConfig clientConfig) { | |||
| prioritizeVipAddressBasedServers = Boolean.parseBoolean(""+clientConfig.getProperty(CommonClientConfigKey.PrioritizeVipAddressBasedServers, prioritizeVipAddressBasedServers)); | |||
| datacenter = ConfigurationManager.getDeploymentContext().getDeploymentDatacenter(); | |||
| targetRegion = (String) clientConfig.getProperty(CommonClientConfigKey.TargetRegion); | |||
|
|
|||
| shouldUseIpAddr = clientConfig.getPropertyAsBoolean(CommonClientConfigKey.UseIPAddrForServer, false); | |||
There was a problem hiding this comment.
Instead of hardcoded false, we can use DefaultClientConfigImpl.DEFAULT_USEIPADDRESS_FOR_SERVER
|
@aspyker This PR looks good to me except for the two minor comments. Thanks! |
|
ribbon-pull-requests #174 SUCCESS |
allenxwang
pushed a commit
that referenced
this pull request
Sep 9, 2014
add UseIPAddrForServer configuration to not require DNS for 2.x/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.