Support configuring scheme for Server #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
approved these changes
Jun 14, 2017
|
@twicksell @elandau @qiangdavidliu @tcellucci [1] https://github.com/Netflix/ribbon#project-status-on-maintenance |
qiangdavidliu
approved these changes
Jun 15, 2017
| @@ -93,6 +94,14 @@ public Server(String host, int port) { | |||
| this.id = host + ":" + port; | |||
| isAliveFlag = false; | |||
| } | |||
|
|
|||
| public Server(String scheme, String host, int port) { | |||
There was a problem hiding this comment.
Minor nit, can you also update the other constructor to call this(null, host, port)?
There was a problem hiding this comment.
Addressed on 6646ac8
|
Thanks for the contrib @mattnelson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a
Serverto optionally have a scheme. This allows for aServerListto support instances with different schemes which enables the gradual migration to secure services without a big bang flip over.Related to #275 which could not be accepted due to concerns about passivity. This change will allow me to extend
ConfigurationBasedServerListand provide the scheme/port on construction of theServerand abstracts the ribbon client IsSecure/SecurePort properties into the individualServerinstance.Without this change I will likely be forced to fork ribbon internally, which I would really like to avoid doing. Added a plethora of tests increase the probability of acceptance.