Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Untagged archive returns no version string #227

Closed
dzhoshkun opened this issue Sep 13, 2018 · 0 comments
Closed

Untagged archive returns no version string #227

dzhoshkun opened this issue Sep 13, 2018 · 0 comments

Comments

@dzhoshkun
Copy link
Collaborator

The get_niftynet_version function returns None when the archive downloaded from GitHub is not from a tagged commit. However even in this case we would like to be able to trace the version of the NiftyNet source code, which in this particular case would be provided by the version_info['full-revisionid'] element.
dzhoshkun added a commit that referenced this issue Sep 13, 2018
@dzhoshkun
Issue #227: CI dev test now checks no 'unknown' in git-archive'd vers…
4bb876b 
…ion string
dzhoshkun added a commit that referenced this issue Sep 13, 2018
@dzhoshkun
Issue #227: using full revision ID as version string, if available
badec72
@dzhoshkun dzhoshkun mentioned this issue Sep 13, 2018
Merged
@wyli wyli closed this as completed in #228 Sep 13, 2018
wyli added a commit that referenced this issue Sep 13, 2018
@wyli
Merge pull request #228 from NifTK/227-untagged-archive-returns-no-ve…
85d8af4 
…rsion-string

Untagged archive now returns full revision ID as version string (fixes #227)
elitap pushed a commit to elitap/NiftyNet that referenced this issue Oct 30, 2018
@wyli
Merge branch '227-create-the-__version__-variable-in-niftynet-__init_…
711478d 
…_-py' into 'dev'

Resolve "create the `__version__` variable in `niftynet/__init__.py`"

Closes NifTK#227

See merge request CMIC/NiftyNet!215
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dzhoshkun