cc-wrappers should unconditionally provide target prefixed tools ${target}-gcc to shadow unwrapped bianries.

[trofi]

Noticed the unwrapped binary leak in when built enchant1 with config.configurePlatformsByDefault = true; (pass --host= for native builds). There linkage fails because CC=x86_64-unknown-linux-gnu-gcc points to unwrapped binary:

$ ls /nix/store/5k57n0irf29smr12ib721dzh2ffqwlp6-gcc-wrapper-13.0.0/bin
as  c++  cc  cpp  g++  gcc  ld  ld.bfd  ld.gold  strip
$ ls /nix/store/fzwli194jbp7dv9s874sd6pn318q6h3c-gcc-13.0.0/bin
c++  g++  gcc-ar  gcc-ranlib  gcov-dump  lto-dump                      x86_64-unknown-linux-gnu-g++  x86_64-unknown-linux-gnu-gcc-13.0.0  x86_64-unknown-linux-gnu-gcc-nm
cpp  gcc  gcc-nm  gcov        gcov-tool  x86_64-unknown-linux-gnu-c++  x86_64-unknown-linux-gnu-gcc  x86_64-unknown-linux-gnu-gcc-ar      x86_64-unknown-linux-gnu-gcc-ranlib

--host=${target} effectively flips CC from gcc-wrapper to gcc. I'm surprised there is that little breakage. I'd say gcc-wrapper should always provide both gcc (& co) and ${target}-gcc (& co).

Proposal: install ${target}-gcc for native wrappers along with gcc.

Optionally we can disable unprefixed tools as suggested by the TODO:

nixpkgs/pkgs/build-support/cc-wrapper/default.nix

Lines 37 to 40 in 7b185e0

	# TODO(@Ericson2314) Make unconditional, or optional but always true by
	# default.
	targetPrefix = lib.optionalString (targetPlatform != hostPlatform)
	(targetPlatform.config + "-");

. But that will surely be a big breaking change. Better guard it under a flag initially.

[trofi]

/cc @Ericson2314

[trofi]

I'll ignore binutils-wrappers for now.

here our current sets of files typically present in various packages and their wrappers (picking a simple example):

$ nix-shell --pure -A lv

# unwraped binutils tools:
$$ ls /nix/store/f0rrfmf8kh5bsiql5bbq7m4h3xgihpnx-binutils-2.38/bin/
addr2line  ar  as  c++filt  dwp  elfedit  gprof  ld  ld.bfd  ld.gold  nm  objcopy  objdump  ranlib  readelf  size  strings  strip

# wrapped binutils tools (not normally used directly)
$$ ls /nix/store/5fly14l1fc49v395rn2jcp8aq6ndcb5v-binutils-wrapper-2.38/bin
as  ld  ld.bfd  ld.gold  strip

# unwrapped gcc tools:
$$ /nix/store/zs6hnk47hcrrcrd885d66xmhlvp05jxm-gcc-11.3.0/bin
c++  g++  gcc-ar  gcc-ranlib  gcov-dump  lto-dump                      x86_64-unknown-linux-gnu-g++  x86_64-unknown-linux-gnu-gcc-11.3.0  x86_64-unknown-linux-gnu-gcc-nm
cpp  gcc  gcc-nm  gcov        gcov-tool  x86_64-unknown-linux-gnu-c++  x86_64-unknown-linux-gnu-gcc  x86_64-unknown-linux-gnu-gcc-ar      x86_64-unknown-linux-gnu-gcc-ranlib

# wrapped gcc tools:
$$ ls /nix/store/d7d0ccp06rblhwk9sqnqn4lynijbjgv6-gcc-wrapper-11.3.0/bin
as  c++  cc  cpp  g++  gcc  ld  ld.bfd  ld.gold  strip

For simplest cases we can wrap not just ${tool}, but also check if ${target}-${tool} is present and wrap that.

[trofi]

Proposed fix as #181724. Fixes at least radare2.