-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-runner: <name>.enable has no effect #305304
Labels
0.kind: bug
Something is broken
Comments
@chreekat would you be willing to fix up this issue? i believe it would be fairly easy issue to resolve. |
Yes, if I hadn't noticed this while deep in the middle of another task I would have just done it! I have it on my "easy" list, but I can't promise how quickly I will get to it. |
great! thank you so much please feel free to ping me on that PR when you get around to it |
13 tasks
growler
pushed a commit
to growler/nixpkgs
that referenced
this issue
Oct 16, 2024
vinylen
pushed a commit
to vinylen/nixpkgs
that referenced
this issue
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The config doesn't seem to be guarded on the
enable
option. :)Expected behavior:
If
services.github-runner.foo.enable = false
, then that github-runner shouldn't be enabledActual behavior:
The runner is enabled regardless of the
enable
setting./cc @veehaitch @newAM
The text was updated successfully, but these errors were encountered: