Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-runner: <name>.enable has no effect #305304

Closed
chreekat opened this issue Apr 19, 2024 · 4 comments · Fixed by #342996
Closed

github-runner: <name>.enable has no effect #305304

chreekat opened this issue Apr 19, 2024 · 4 comments · Fixed by #342996
Labels
0.kind: bug Something is broken

Comments

@chreekat
Copy link
Contributor

The config doesn't seem to be guarded on the enable option. :)

Expected behavior:

If services.github-runner.foo.enable = false, then that github-runner shouldn't be enabled

Actual behavior:

The runner is enabled regardless of the enable setting.

/cc @veehaitch @newAM

@aanderse
Copy link
Member

@chreekat would you be willing to fix up this issue? i believe it would be fairly easy issue to resolve.

@chreekat
Copy link
Contributor Author

Yes, if I hadn't noticed this while deep in the middle of another task I would have just done it! I have it on my "easy" list, but I can't promise how quickly I will get to it.

@aanderse
Copy link
Member

aanderse commented May 1, 2024

great! thank you so much

please feel free to ping me on that PR when you get around to it

@chreekat
Copy link
Contributor Author

@aanderse #342996

growler pushed a commit to growler/nixpkgs that referenced this issue Oct 16, 2024
vinylen pushed a commit to vinylen/nixpkgs that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants