treewide: move fixDarwinDylibNames to nativeBuildInputs #100388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefloweringash
force-pushed
the
darwin-dylib-names-hook
branch
3 times, most recently
from
837c8e8 to
9488d79
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
LnL7
suggested changes
Oct 13, 2020
| ]; | ||
|
|
||
| propagatedNativeBuildInputs = |
There was a problem hiding this comment.
This should never be propagated, that makes it impossible to build libraries with rpath or executable relative references when this is a dependency.
10 tasks
|
needs a rebase |
This hook runs at build time and depends on executing install_name_tool from binutils.
This package is a leaf that exports no libraries, so propagating its inputs should have no effect. The fixDarwinDylibNames hook only applies to *.dylib files, which this package does not contain.
thefloweringash
force-pushed
the
darwin-dylib-names-hook
branch
from
4175101 to
5b5d38a
Compare
|
Rebased! |
LnL7
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hopefully simple cleanup. I discovered some inconsistencies when cross compiling where install_name_tool has a target prefix, and checked through the uses in the entire tree.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)