-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc: fix Darwin cross compilation for 2.32 #107744
Conversation
Have you tried running a resulting binary on Linux? In #103517 (which I think this might be a dupe of), I needed another fix to make that work. edit: oops, running, not building |
Thanks for making me aware of this other pull request. So far I was using the cross compiler to build a Linux kernel on Darwin and this works with just the change I PR’d here. So I guess these two things (the change mentioned here and the additional change in #103517) are somewhat independent. |
Oh, dang, you got a kernel building? Please share! |
This should work (with adjustments, but I guess you can figure that out): I am using this old kernel version, because I am working to get linuxkit-nix running and move forward from the last state there in baby steps. I would hope newer versions work as well. |
Result of 49 packages marked as broken and skipped:
|
This PR fixes cross compilation on Darwin: some parts of the current patch are no longer needed. For the rest, I updated the line numbers so patch applies cleanly again.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)