Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv/check-meta: remove onlyLicenses check #160467

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

ncfavier
Copy link
Member

Fixes #154031. I could not find a reason for this check to exist and @wmertens has not replied. meta.license needs not be an attribute of lib.licenses, so allow/blocklists should not either.

cc @ony @roberth

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Feb 17, 2022
@wmertens
Copy link
Contributor

So, making sure that the license is a known license is not desirable?

@ncfavier
Copy link
Member Author

The nixpkgs manual says this:

The meta.license attribute should preferably contain a value from lib.licenses defined in nixpkgs/lib/licenses.nix, or in-place license description of the same format if the license is unlikely to be useful in another expression.

In any case, this check isn't ensuring that meta.license is known, only that the block/allowlisted licenses are. The latter would maybe make sense if the former was done, but it's not.

@wmertens
Copy link
Contributor

ah right. 👍 then.

@roberth roberth requested a review from alyssais February 17, 2022 13:01
@ncfavier
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 20, 2022
@ncfavier ncfavier requested a review from roberth March 7, 2022 09:20
@roberth roberth merged commit 556c5bf into NixOS:master Mar 7, 2022
@ncfavier ncfavier deleted the no-onlyLicenses branch March 7, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
3 participants