lib.modules: Allow making _module.args internal #167776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Apr 8, 2022
lib/modules.nix
Outdated
| internal = prefix != []; | ||
| # Allow other mkOption decls to make this internal regardless. | ||
| ${if prefix == [] | ||
| then null # unset; default is true |
There was a problem hiding this comment.
I'm pretty sure the default is false? How does this even still get rendered with that?
There was a problem hiding this comment.
Right, I must have been thinking of visibility instead of internalness. Now it's:
then null # unset => visible
roberth
force-pushed
the
lib-modules-allow-disable-_modules.args-docs-internal
branch
from
35f40b2 to
1e9b970
Compare
This allows other module system consumers to disable these docs via option merging. For instance arion uses asciidoc instead of docbook so that would look awful.
roberth
force-pushed
the
lib-modules-allow-disable-_modules.args-docs-internal
branch
from
1e9b970 to
14aa201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Makes #165540 opt-out.
This allows other module system consumers to disable these docs using option merging.
For instance arion uses asciidoc instead of docbook so that would look awful.
Implementation note:
I figured a dynamic attr would perform better than an
optionalAttrscall + extra attrset garbage.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes