Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elisp-packages: fix AOT native-comp for several packages #194278

Merged
merged 1 commit into from
Oct 4, 2022
Merged

elisp-packages: fix AOT native-comp for several packages #194278

merged 1 commit into from
Oct 4, 2022

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Oct 3, 2022 •
edited
Loading

Currently, AOT native-comp for emacs packages is implemented1 in postInstall. These packages override postInstall and do not keep old.postInstall, so they do not do AOT native-comp. This patch fixes this by keeping the old.postInstall in their overrides.

Note that I do not fix emacspeak (@AndersonTorres ) because I have not found an elegant way to do so.

Description of changes
Things done

I tested vterm and emacsql-sqlite.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jian-lin
elisp-packages: fix AOT native-comp for several packages
92e4b65 
Currently, AOT native-comp for emacs packages is implemented[1] in
postInstall. These packages override postInstall and do not keep
old.postInstall, so they do not do AOT native-comp. This patch fixes
this by keeping the old.postInstall in their overrides.

Note that I do not fix emacspeak because I have not found an elegant
way to do so.

[1]: a7cb8e3
@jian-lin jian-lin requested a review from adisbladis as a code owner October 3, 2022 19:39
@github-actions github-actions bot added the 6.topic: emacs Text editor label Oct 3, 2022
@ofborg ofborg bot requested a review from sternenseemann October 3, 2022 19:56
@adisbladis adisbladis merged commit 553d58a into NixOS:master Oct 4, 2022
@jian-lin jian-lin deleted the fix-emacs-native-comp-for-some-packages branch October 4, 2022 03:34
@jian-lin jian-lin mentioned this pull request Oct 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jian-lin @sternenseemann @adisbladis