Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass lib throughout NixOS and pkgs #210568

Closed
wants to merge 4 commits into from
Closed

Pass lib throughout NixOS and pkgs #210568

wants to merge 4 commits into from

Conversation

RossComputerGuy
Copy link
Member

Description of changes

The idea for this PR is to allow people to override lib, this is great for people who wish to hack onto nixpkgs and helps ensure they don't have to copy files from nixpkgs into their own code to pass their replacement lib.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 13, 2023
@RossComputerGuy RossComputerGuy marked this pull request as draft January 13, 2023 19:27
@RossComputerGuy
Copy link
Member Author

This will be a draft until I have confirmation that lib is being passed around correctly as intended.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 13, 2023
@Artturin
Copy link
Member

The idea for this PR is to allow people to override lib

dupe of #157056

@Artturin Artturin closed this Jan 13, 2023
@RossComputerGuy RossComputerGuy deleted the lib-passthru branch January 13, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants