Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn-lock-converter: init at 0.0.2 #231687

Merged
merged 1 commit into from
May 16, 2023
Merged

yarn-lock-converter: init at 0.0.2 #231687

merged 1 commit into from
May 16, 2023

Conversation

gador
Copy link
Member

@gador gador commented May 13, 2023 •
edited
Loading

Description of changes

https://www.npmjs.com/package/@vht/yarn-lock-converter?activeTab=readme

Allows to convert v2 and v3 yarn.lock files to convert to v1 lockfiles.

EDIT:

Yes, I've seen #229475. Unfortunately upstream only provides a yarn.lock file and no package-lock.json file.
(see below)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 13, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2217

gador added a commit to gador/nixpkgs that referenced this pull request May 15, 2023
@gador
pgadmin4: 7.0 -> 7.1
fa770ef 
Upstream has changed their `yarn.lock` file format to v2.
This introduces complications with nixpkgs, which needs the v1
file format. There is also a number of problems with the v2 version
(e.g. reproducibility or missing integrity fields) which makes the
direct use of v2 lockfile impossible.

Due to this change, we will need to convert the lockfile beforehand
and add it to nixpkgs. Due to issues with reproducibility it isn't
feasable to convert the lockfile within the `pgadmin` derivation.

For this commit I added the converted `yarn.lock` file and will add the
corresponding update script, once NixOS#231687 has been merged. (This adds
the tool to convert most of the v2 file to v1 and adds metadata to the
lockfile)

Signed-off-by: Florian Brandes <[email protected]>
@gador gador mentioned this pull request May 15, 2023
Merged
12 tasks
@SuperSandro2000
Copy link
Member

Please see #229475 how to package new cli tools.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft May 15, 2023 13:19
@gador
Copy link
Member Author

gador commented May 15, 2023 •
edited
Loading

Please see #229475 how to package new cli tools.

I've seen this PR. I even mentioned it in the description. Please see my comment there.

EDIT:
In contrast to what I said, it is possible to package nodejs packages without a package-lock.json. I looked at #230158 and how @teutat3s packaged node-manta and transferred it to this package.

@SuperSandro2000 could you have another look? Thanks

@gador gador requested a review from SuperSandro2000 May 15, 2023 13:40
@gador gador force-pushed the add_yarn-lock-converter branch 2 times, most recently from b46f7f8 to 010abec Compare May 15, 2023 14:38
@gador gador marked this pull request as ready for review May 15, 2023 14:45
SuperSandro2000
SuperSandro2000 reviewed May 15, 2023
View reviewed changes
pkgs/tools/package-management/yarn-lock-converter/default.nix
inherit (source) version;

src = fetchurl {
url = "https://registry.npmjs.org/@vht/yarn-lock-converter/-/yarn-lock-converter-${version}.tgz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a fetcher for this.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 15, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/945

@gador
yarn-lock-converter: init at 0.0.2
619d577 
Signed-off-by: Florian Brandes <[email protected]>
@gador gador force-pushed the add_yarn-lock-converter branch from 010abec to 619d577 Compare May 16, 2023 09:53
@gador gador changed the title nodePacakges.yarn-lock-converter: init at 0.0.2 yarn-lock-converter: init at 0.0.2 May 16, 2023
@gador
Copy link
Member Author

gador commented May 16, 2023

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 231687 run on x86_64-linux 1

1 package built:
  • yarn-lock-converter

@SuperSandro2000 SuperSandro2000 merged commit ab4a501 into NixOS:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gador @nixos-discourse @SuperSandro2000