Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

durdraw: init at 0.20.2, ansilove: init at 4.2.0, libansilove: init at 1.4.1 #235730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

foo-dogsquared
Copy link
Member

@foo-dogsquared foo-dogsquared commented Jun 3, 2023

Description of changes

(Feel free to let me know if Durdraw and Ansilove should be in separate PRs for easier review.)

Add Durdraw, an ASCII art editor. I also added Ansilove, one of the dependencies, since it is missing in the repo.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

fixes #286856

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jun 3, 2023
@foo-dogsquared foo-dogsquared changed the title durdraw: init at 0.20.1, ansilove: init at 4.2.0, libansilove: init at 1.4.1 durdraw: init at 0.20.2, ansilove: init at 4.2.0, libansilove: init at 1.4.1 Jun 10, 2023
@foo-dogsquared
Copy link
Member Author

Updated Durdraw to 0.20.2.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add meta.changelog and meta.mainProgram where you can.

hash = "sha256-J5kDnK0Fp2E/7aaBRB1kuew9g2uSdRQ84k0WFWco9SE=";
};

propagatedBuildInputs = [ ansilove ] ++ (with python3Packages; [ pillow ]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is ansilove propagated?


python3Packages.buildPythonApplication rec {
pname = "durdraw";
version = "0.20.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.20.2";
version = "0.20.2";
pyproject = true;

and maybe add setuptool to nativeBuildInputs.


src = fetchFromGitHub {
owner = "cmang";
repo = pname;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = pname;
repo = "durdraw";

See #277994.

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@ghost
Copy link

ghost commented Aug 8, 2024

durdraw v0.27.1 is available. And merge when!!

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 8, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Durdraw
3 participants