-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
durdraw: init at 0.20.2, ansilove: init at 4.2.0, libansilove: init at 1.4.1 #235730
base: master
Are you sure you want to change the base?
Conversation
fa20384
to
d2b3097
Compare
Updated Durdraw to 0.20.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add meta.changelog
and meta.mainProgram
where you can.
hash = "sha256-J5kDnK0Fp2E/7aaBRB1kuew9g2uSdRQ84k0WFWco9SE="; | ||
}; | ||
|
||
propagatedBuildInputs = [ ansilove ] ++ (with python3Packages; [ pillow ]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is ansilove propagated?
|
||
python3Packages.buildPythonApplication rec { | ||
pname = "durdraw"; | ||
version = "0.20.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "0.20.2"; | |
version = "0.20.2"; | |
pyproject = true; |
and maybe add setuptool
to nativeBuildInputs
.
|
||
src = fetchFromGitHub { | ||
owner = "cmang"; | ||
repo = pname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = pname; | |
repo = "durdraw"; |
See #277994.
durdraw v0.27.1 is available. And merge when!! |
Description of changes
(Feel free to let me know if Durdraw and Ansilove should be in separate PRs for easier review.)
Add Durdraw, an ASCII art editor. I also added Ansilove, one of the dependencies, since it is missing in the repo.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)fixes #286856