Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: Fix systemd-boot test #237063

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented Jun 10, 2023

Description of changes

Apparently the nodes don't share the host store anymore?

cc @RaitoBezarius is this necessary or is it a bug in the test framework? I don't see where the test disables forwarding of the host store.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

roberth added 2 commits June 10, 2023 17:51
@roberth roberth requested a review from RaitoBezarius June 10, 2023 15:54
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 10, 2023
@roberth
Copy link
Member Author

roberth commented Jun 10, 2023

@ofborg test systemd-boot.switch-test

@RaitoBezarius
Copy link
Member

cc @RaitoBezarius is this necessary or is it a bug in the test framework? I don't see where the test disables forwarding of the host store.

With bootloaders (i.e. "full system images"), you get your own /nix/store, I was exploring getting "noNixStore" in those situations for tests that does not require it: #227883

It is a fallout of mountHostNixStore = !useBootLoader; default.

It's more like a target for further refactor/fixes.

@RaitoBezarius
Copy link
Member

Precise analysis here: #227881 (comment)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 10, 2023
@roberth roberth merged commit 493b08c into NixOS:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants