rustc: remove Darwin special-casing #242749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to remove it was made in NixOS#106886, but there was a build failure. Since that failure no longer occurs, remove it now. Based on thefloweringash/nixpkgs@1904236.
reckenrode
requested review from
Mic92,
zowoq,
winterqt and
figsoda
as code owners
|
Just for clarity, what specifically changed that causes the failure not to occur anymore? Or can you not pin it down to the massive amount of work being put into the LLVM bump? |
zowoq
approved these changes
Jul 11, 2023
I can’t say, unfortunately. I was looking to bump the bootstrap version for the clang 16 bump when I found the old issue and the commit from @thefloweringash’s repo. I applied it to current nixpkgs, and it still works. I assume it’s a combination of improvements in the LLVM environment and Darwin packaging that resolved the missing symbol issue. |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
tjni
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
An attempt to remove it was made in #106886, but there was a build failure. Since that failure no longer occurs, remove it now.
Based on thefloweringash/nixpkgs@1904236.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)