-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texlive: some small refactors #250621
texlive: some small refactors #250621
Conversation
One of the test fails on my machine, but also did before this PR:
|
e2e1127
to
8e9748c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful and overdue, and with zero user visible changes so safe to merge quickly.
@GrahamcOfBorg build tests.texlive.licenses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please rebase |
This prepares the use of callPackage (to avoid repeating the parameter names all over the place) and makes static analysis possible
8e9748c
to
babce2f
Compare
Description of changes
These changes move some code around to make texlive more managable. This should not cause any rebuilds.
This is split off from the texlive scopification PR I'll create right after this in the hope that this can be merged almost immediately and I won't have to rebase these commits.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)