Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: some small refactors #250621

Merged
merged 3 commits into from
Aug 27, 2023
Merged

Conversation

apfelkuchen6
Copy link
Contributor

Description of changes

These changes move some code around to make texlive more managable. This should not cause any rebuilds.

This is split off from the texlive scopification PR I'll create right after this in the hope that this can be merged almost immediately and I won't have to rebase these commits.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Aug 21, 2023
@apfelkuchen6
Copy link
Contributor Author

One of the test fails on my machine, but also did before this PR:

texlive-test-binaries> building '/nix/store/6a16fffzdsh183b7jjb86hsp80nkg96b-texlive-test-binaries.drv'
texlive-test-binaries> failed 'pdfclose --version' (exit code: 1)
texlive-test-binaries> tested 436 binaries: 17 ignored, 2 broken, 1 failed

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 21, 2023
@apfelkuchen6 apfelkuchen6 force-pushed the texlive-noop-refactors branch from e2e1127 to 8e9748c Compare August 22, 2023 08:04
Copy link
Contributor

@xworld21 xworld21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful and overdue, and with zero user visible changes so safe to merge quickly.

@GrahamcOfBorg build tests.texlive.licenses

@xworld21 xworld21 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 22, 2023
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl
Copy link
Member

veprbl commented Aug 26, 2023

Please rebase

This prepares the use of callPackage (to avoid repeating the parameter names all
over the place) and makes static analysis possible
@apfelkuchen6 apfelkuchen6 force-pushed the texlive-noop-refactors branch from 8e9748c to babce2f Compare August 27, 2023 10:36
@veprbl veprbl merged commit bf6e5e7 into NixOS:master Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants