Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guile: fix build with clang 16 on x86_64-darwin #252438

Merged
merged 2 commits into from
Sep 28, 2023
Merged

guile: fix build with clang 16 on x86_64-darwin #252438

merged 2 commits into from
Sep 28, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Guile 2.2 and 3.0 use __sincos, which should be part of the 10.12 SDK but is not due to the header being out of date. This results in a build failure with clang 16. Using the 11.0 SDK works around the issue.

While there shouldn’t be any rebuilds except on x86_64-darwin, targeting staging because it has ~700.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
guile_2_2: fix build with clang 16 on x86_64-darwin
98bd317 
Guile 2.2 calls `__sincos`, which should be defined in `math.h`, but the
version of that header in the 10.12 SDK is very old (predating 10.12).
Until there is a version of that header available, use the 11.0 SDK to
build Guile.
@reckenrode
guile_3_0: fix build with clang 16 on x86_64-darwin
f838258 
Guile 3.0 calls `__sincos`, which should be defined in `math.h`, but the
version of that header in the 10.12 SDK is very old (predating 10.12).
Until there is a version of that header available, use the 11.0 SDK to
build Guile.
@reckenrode reckenrode mentioned this pull request Aug 30, 2023
Closed
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 30, 2023
@ofborg ofborg bot requested review from vrthra and lovek323 August 30, 2023 22:31
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 30, 2023
@vcunat vcunat merged commit 2b7f43b into NixOS:staging Sep 28, 2023
@reckenrode reckenrode deleted the guile-fix branch October 27, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @vcunat