Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.kivy: fix build on Darwin #262816

Merged
merged 1 commit into from
Oct 23, 2023
Merged

python3Packages.kivy: fix build on Darwin #262816

merged 1 commit into from
Oct 23, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

  • Add the Accelerate framework as a buildInput; and
  • Fix incompatible function pointer conversion errors with clang 16.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode reckenrode mentioned this pull request Oct 22, 2023
Closed
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 22, 2023
@ofborg ofborg bot requested a review from rissson October 22, 2023 23:51
@reckenrode @wegank
python3Packages.kivy: fix build on Darwin
d466a34 
* Add the Accelerate framework as a `buildInput`; and
* Fix incompatible function pointer conversion errors with clang 16.

Co-authored-by: Weijia Wang <[email protected]>
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 23, 2023
@wegank
Copy link
Member

wegank commented Oct 23, 2023

Result of nixpkgs-review pr 262816 run on aarch64-darwin 1

8 packages built:
  • nsz (python311Packages.nsz)
  • nsz.dist (python311Packages.nsz.dist)
  • python310Packages.kivy
  • python310Packages.kivy.dist
  • python310Packages.nsz
  • python310Packages.nsz.dist
  • python311Packages.kivy
  • python311Packages.kivy.dist

@wegank wegank merged commit eae5987 into NixOS:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@rissson rissson rissson approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reckenrode @wegank @rissson @delroth